empty socket error propagation

src/common.rs

@@ -15,7 +15,7 @@ const PUBLIC_IPV6: &str = "https://ipv6.icanhazip.com";
 
 #[derive(Debug, PartialEq, Eq)]
 pub enum Message {
-    ErrorMsg(String),
+    Error(String),
     Files(Vec<PathBuf>),
     Metadata(HashMap<String, (u64, String)>),
     ClientConnect(SocketAddr),

src/comms.rs

@@ -41,7 +41,7 @@ pub async fn recv(
     let n = reader.read_until(b':', &mut buf).await?;
 
     if n == 0 {
-        todo!("maybe error handling :)");
+        return Err("Received 0 bytes from the socket".into());
     }
 
     buf.pop();

src/connector.rs

@@ -83,7 +83,7 @@ impl Connector {
         let msg = String::from_utf8(buf)?;
 
         if msg == "FIN" {
-            todo!("maybe error handling :)");
+            return Err("Incorrect access key".into());
         }
 
         Ok(())

src/listener.rs

@@ -55,15 +55,23 @@ impl Listener {
             let files = files.clone();
             let (mut socket, addr) = listener.accept().await?;
             tx.send(Message::ClientConnect(addr)).await?;
-            let this_tx = tx.clone();
+            let conn_tx = tx.clone();
-            let this_self = Arc::clone(&self);
+            let err_tx = tx.clone();
+            let conn_self = Arc::clone(&self);
 
-            tokio::spawn(async move {
+            match tokio::spawn(async move {
-                this_self
+                conn_self
-                    .connection(&mut socket, addr, this_tx, &files)
+                    .connection(&mut socket, addr, conn_tx, &files)
-                    .await?;
+                    .await
-                Ok::<(), Box<dyn Error + Send + Sync>>(())
+            })
-            });
+            .await
+            {
+                Ok(_) => {}
+                Err(e) => {
+                    let err_msg = format!("{}: {}", addr, e);
+                    err_tx.send(Message::Error(err_msg)).await?;
+                }
+            };
         }
     }
 
@@ -162,7 +170,7 @@ impl Listener {
         let msg = String::from_utf8(buf)?;
 
         if msg != "AMT" {
-            todo!("maybe error handling :)");
+            return Err("Broken message sequence".into());
         }
 
         for file in metadata {
@@ -217,7 +225,7 @@ impl Listener {
             let msg = String::from_utf8(buf)?;
 
             if msg == "ERROR" {
-                todo!("maybe error handling :)");
+                return Err("Incomplete file request (hashes don't match)".into());
             }
         }